llnl / llnl/thicket

Statsframe functions are currently sorted by default

Open
#215 0 comments 0 reactions 0 assignees View on GitHub
area-stats priority-normal
Dominant language
JavaScript
Stars
18
Forks
10
PR merge metrics
No merged PRs in 30d

Description

As it currently stands, there is a precedent in Thicket such that all statsframe operations sort the statsframe dataframe. This is extra behavior that is done on the behalf of the user.

For some context, Treecs seems to have added this behavior in over a year ago.

Given this, i propose two options:
1. Keep things as is. Ever statsframe functionality here forth will enforce a standard that entail ts the sorting of the statsframe dataframe.
2. We remove the default sorting and instead create a function available to the user that does the work of sorting the statsframe dataframe.

Contributor guide

Open the contributing guide

Research direction

Start by locating the statsframe operations and the code that sorts their dataframes; the issue does not name specific files or tests. Review how Treecs established the behavior, then determine which of the two proposed policies the project accepts; done requires a consistent decision across existing and future statsframe functionality.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
analytics
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.