llnl / llnl/thicket

Check for non-unique multi-index

Open
#172 0 comments 0 reactions 1 assignee View on GitHub

@michaelmckinsey1 is already working on this.

Since Jun 11, 2024.

Dominant language
JavaScript
Stars
18
Forks
10
PR merge metrics
No merged PRs in 30d

Description

From `ensemble.py`:
```
except ValueError as e:
estr = str(e)
if estr == "cannot handle a non-unique multi-index!":
warnings.warn(
"Non-unique multi-index for DataFrame in _fill_perfdata. Cannot Fill missing rows.",
RuntimeWarning,
)
else:
raise
```
As stated from a [previous comment](https://github.com/LLNL/thicket/pull/168#discussion_r1635527518), instead of checking the error string, we should check if the index is non-unique.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.