Validation for Unset Linear Solver
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 686
- Forks
- 167
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 17
Description
When using the Newton solver with the linear solver unspecified, a segfault can occur at
https://github.com/LLNL/sundials/blob/c28eaa3764a03705d61decb6025b409360e9d53f/src/sunnonlinsol/newton/sunnonlinsol_newton.c#L247
This was noticed in #597 which uses CVDOE, and I've seen similar behavior with ARKODE.
Additional validation is needed to alert users that a linear solver should be specified.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/sunnonlinsol/newton/sunnonlinsol_newton.c around line 247 and inspect the Newton solver path when no linear solver is supplied. Trace the CVODE and ARKODE cases mentioned in the issue. Done means both cases report that a linear solver is required instead of reaching a possible segfault.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- hpc
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100