llnl / llnl/sundials

[BUG] ARKodeSetDefaults assumes ReInit

Open
#569 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug triage
Dominant language
C
Stars
686
Forks
167
Avg merge
1d 20h
Merged PRs (30d)
17

Description

Current Behavior:

As mentioned in #560, when restoring the default settings with ARKodeSetDefaults the integrator is put in a state where a call to ARKReInit is necessary before calling Evolve.

Expected Behavior:

This behavior needs to documented or updated such that Evolve may be called after ARKodeSetDefaults.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the ARKodeSetDefaults, ARKReInit, and Evolve entry points, and review the related behavior described in issue #560. Determine whether the expected resolution is documentation or allowing Evolve directly after restoring defaults. Done means the documented lifecycle and actual API behavior agree.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
backend-api-design, hpc
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.