essential attributes in HybridSolver
Open
@barker29 is already working on this.
Since Jul 5, 2019.
- Dominant language
- C++
- Stars
- 13
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Description
The HybridSolver constructors have ess_attr as an optional argument. If it is not provided, MixedLaplacianSolver::Init will not initialize ess_edofs_, so it is a zero-length Array<int>. But then in HybridSolver::CollectEssentialDofs it is assumed that this Array has length num_multiplier_dofs_, so you get a failed assert in MFEM.
There are several ways to fix this, but in practice I think we are always passing ess_attr to the solver constructors, so maybe the simplest solution is to just require this argument rather than having it be optional.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.