Disable Newton iterations for patch tests
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 245
- Forks
- 36
- Avg merge
- 8d 23h
- Merged PRs (30d)
- 4
Description
This is a great catch. It's troubling that none of our other tests were sensitive to this. I guess that our patch tests were passing because they were taking more than 1 Newton iteration, and we recovered the essential boundary conditions on the second and subsequent Newton iterations.
I think we would catch this if we disallow Newton iterations on the patch tests. The patch solutions are linear, so the warm start should hit the exact solution without any subsequent Newton iterations.
Originally posted by @btalamini in https://github.com/LLNL/serac/issues/941#issuecomment-1564949799
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the patch tests and the code that controls their Newton iterations. Run the patch tests first to confirm that they currently permit subsequent iterations; done means the tests disallow those iterations while still passing with the linear warm-start solution.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100