Inconsistent capitalization in single letter variables
Open
Nobody has claimed this yet.
bugfix day
documentation
enhancement
- Dominant language
- C++
- Stars
- 245
- Forks
- 36
- Avg merge
- 8d 23h
- Merged PRs (30d)
- 4
Description
I noticed some inconsistent capitalization (U vs u, dU_dt vs du_dt) in a function. I don't know how pervasive this is but we should at least be consistent.
Example:
https://github.com/LLNL/serac/blob/07b8ef1b3658bee2b66b78fe900595e3408e31ac/src/serac/numerics/odes.cpp#L148-L183
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/serac/numerics/odes.cpp at lines 148-183, where the issue identifies inconsistent names such as U versus u and dU_dt versus du_dt. Inspect the surrounding function and search for similar single-letter capitalization differences to determine the affected scope. Done means the relevant variable naming is consistent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100