llnl / llnl/smith

Save dt to Sidre and restore on restart

Open
#721 0 comments 0 reactions 0 assignees View on GitHub
CS quick
Dominant language
C++
Stars
245
Forks
36
Avg merge
8d 23h
Merged PRs (30d)
4

Description

> Edit: This does actually bring up a good point in your thorough comment. We are setting time and cycle but not dt (via `MFEMSidreDataCollection::SetTimeStep`). @jamiebramwell, does the `dt` every change from the input file value?

Yes - `dt` can change from the input deck value.

_Originally posted by @jamiebramwell in https://github.com/LLNL/serac/issues/717#issuecomment-1154125795_

Contributor guide

Open the contributing guide

Research direction

Start with MFEMSidreDataCollection::SetTimeStep and trace how time and cycle are saved and restored during restart. Read the linked discussion in issue 717 for context. Done means a changed dt is persisted to Sidre and restored correctly after restart.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
data
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.