llnl / llnl/smith

Restarts are running for full time step amount

Open
#672 0 comments 0 reactions 1 assignee View on GitHub

@chapman39 is already working on this.

Since May 19, 2022.

bug quick
Dominant language
C++
Stars
245
Forks
36
Avg merge
8d 23h
Merged PRs (30d)
4

Description

Cycle is loaded from previous run here:

https://github.com/LLNL/serac/blob/4c19ba966aeed4bc73b3ac5513fbd45eed370451/src/drivers/serac.cpp#L162

but the time step is not adjusted here:

https://github.com/LLNL/serac/blob/4c19ba966aeed4bc73b3ac5513fbd45eed370451/src/drivers/serac.cpp#L201-L203

This should also be something like this:

```
// Initialize/set the time information
double t;
if (restart_cycle) {
t = // grab time from datacoll based on given cycle;
} else {
t = 0;
}
```

This ends up running the following amount of steps on a restart:

(time step of cycle loaded) + full simulation time step amount = too much!

Thanks to @chapman39 for noticing!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.