llnl / llnl/smith

Add CI that builds Serac w/ `ENABLE_TESTS=OFF`

Open
#517 1 comment 0 reactions 1 assignee View on GitHub

@white238 is already working on this.

Since May 19, 2022.

build CI CS quick
Dominant language
C++
Stars
245
Forks
36
Avg merge
8d 23h
Merged PRs (30d)
4

Description

It is easy for tests to not be guarded by `ENABLE_TESTS`. Since this is not a normal way for a developer to build, downstream users will be the first to hit linking errors (usually of the flavor `-lgtest` being added to the link line and failing).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.