llnl / llnl/smith

Avoid double deinitialization of MFEM's global state when Tribol is shared

Open
#1,655 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
245
Forks
36
Avg merge
8d 23h
Merged PRs (30d)
4

Description

In #1633, we discovered that MFEM's global state is being doube deinitialized. To work around this temporarily, we force Tribol's targets to be static/shared the same as MFEM. This shouldn't be needed but only caused an issue on Docker Ubuntu 24 gcc@14.

Possible solutions:
* Force MFEM to be the same static/shared as our targets in Spack or CMake errors
* Make Axom and Tribol not recreate MFEM target's which possibly is linking MFEM twice (currently they are exporting the targets).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with issue #1633 and inspect the CMake and Spack target configuration for MFEM, Tribol, and Axom, especially how MFEM targets are exported or linked twice. Reproduce on Docker Ubuntu 24 with gcc@14 and verify that MFEM global state is deinitialized only once without forcing Tribol targets to match MFEM's static/shared setting.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.