Dependencies in MFEM are not creating *_FOUND variables
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 245
- Forks
- 36
- Avg merge
- 8d 23h
- Merged PRs (30d)
- 4
Description
Various TPLs are coming from MFEM and we aren't creating variables for it's dependencies. It creates inconsistency in how we check if TPLs are enabled and causes cascading issues as well. Like this config header check isn't being handled either:
Originally posted by @white238 in https://github.com/llnl/smith/pull/1645#discussion_r3787203380
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the MFEM dependency handling in the CMake files and the config-header check at cmake/SmithConfigHeader.cmake lines 10-15. Trace how enabled TPLs are detected and compare the dependency variables with other TPL checks. Done means MFEM dependencies consistently provide their *_FOUND variables and the config-header check handles them without cascading issues.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, cpp
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100