Track if `completeSetup()` has been called in physics modules
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 245
- Forks
- 36
- Avg merge
- 8d 23h
- Merged PRs (30d)
- 4
Description
Add a boolean for if complete setup has been called and add assert to functions that should be called before or after complete setup.
Originally posted by @white238 in https://github.com/llnl/smith/pull/1638#discussion_r3723001196
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the physics modules that implement or call completeSetup(), then identify which functions must run before or after setup. Add tracking for whether setup has completed and assertions at those call points. Done means invalid call order is detected consistently across the affected physics modules.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- hpc
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100