llnl / llnl/smith

parameter set returned from BasePhysics returns in alphabetical order

Open
#1,421 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
245
Forks
36
Avg merge
8d 23h
Merged PRs (30d)
4

Description

This makes it a bit hard to use, as users are wanting to pass parameters back in using the order specified in the functional constructor argument order. We may just need to define the < operator to sort by index order, not name.

Contributor guide

Open the contributing guide

Research direction

Start by locating BasePhysics and the code that orders or compares its returned parameter set. Check how functional-constructor argument positions are represented, then verify that the returned parameters follow that order rather than alphabetical order.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.