llnl / llnl/smith

Move numerical functions to `serac` namespace

Open
#1,349 0 comments 0 reactions 0 assignees View on GitHub
CS refactoring
Dominant language
C++
Stars
245
Forks
36
Avg merge
8d 23h
Merged PRs (30d)
4

Description

These are causing conflicts with other numerical functions and should be guarded by our namespace. We should also evaluate whether they should take `double`'s as arguments.

Contributor guide

Open the contributing guide

Research direction

The issue does not name the files or numerical functions involved. Start by locating the numerical functions that conflict with other functions, then determine the required serac namespace scope and whether their arguments should use double; done means the conflicts are resolved and the argument types have been evaluated.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.