llnl / llnl/smith

Add warning message for parameter fields not set by users

Open
#1,178 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
245
Forks
36
Avg merge
8d 23h
Merged PRs (30d)
4

Description

I've noticed in the solid mechanics module that `completeSetup()` will give numerical errors if certain types of parameters, e.g. Young's modulus, are not initialized (and therefore default to 0). I think LiDO users are susceptible to forgetting to initialize parameter fields before passing the serac solver to a graph node as they are expecting the decision variables from the graph to populate parameter fields within design iterations. Since parameter fields can have many different physical meanings it would be impossible to come up with meaningful defaults, but it would be useful to output a warning message to users if parameter fields are not updated to aid in the debugging process.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the solid mechanics module at completeSetup(), where uninitialized parameter fields such as Young's modulus can produce numerical errors. Trace how parameter fields are updated before setup and identify a suitable point for reporting missing updates. Done means users receive a warning when relevant parameter fields remain at their default state, without changing meaningful parameter defaults.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
hpc
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.