llnl / llnl/smith

Add execution space non-type template parameter to evaluation_kernel_impl

Open
#1,103 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
245
Forks
36
Avg merge
8d 23h
Merged PRs (30d)
4

Description

https://github.com/LLNL/serac/pull/1026 add basic CUDA support to `evaluation_kernel_impl` inside both `boundary_integral_kernels.hpp` and `domain_integral_kernels.hpp`. Some conditional compilation is currently necessary to facilitate this, but could be eliminated by passing a template parameter to toggle GPU/CPU execution.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review PR 1026 and the execution paths in boundary_integral_kernels.hpp and domain_integral_kernels.hpp. Determine how the execution-space template parameter should toggle GPU versus CPU execution and where the current conditional compilation is used. Done means both evaluation_kernel_impl implementations accept the parameter and the existing CUDA and CPU paths remain supported.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
hpc
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.