Investigate initialization of previous_dt_ to -1
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 245
- Forks
- 36
- Avg merge
- 8d 23h
- Merged PRs (30d)
- 4
Description
Not necessarily in this PR, but at some point, can we add a comment on why this value of `previous_dt_` is needed? Is it connected to the particular implementation of backward Euler?
Originally posted by @btalamini in https://github.com/LLNL/serac/pull/1057#discussion_r1434321592
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the codebase for the initialization and uses of previous_dt_, then read the surrounding backward Euler implementation to determine why it starts at -1. Add a nearby comment explaining that rationale and verify the relevant simulation behavior remains unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- hpc
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100