Using `MPI_COMM_WORLD` instead of mesh-specific communicator in data collection construction
Open
Nobody has claimed this yet.
bug
CS
- Dominant language
- C++
- Stars
- 245
- Forks
- 36
- Avg merge
- 8d 23h
- Merged PRs (30d)
- 4
Description
When we create a new data collection in the state manager, we use `MPI_COMM_WORLD` instead of the communicator used by the mesh. This will break if a downstream user has previously defined custom communicators.
See:
https://github.com/LLNL/serac/blob/da503159a97d3dd3e9fad5ec2bc17ef981037126/src/serac/physics/state/state_manager.cpp#L36
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/serac/physics/state/state_manager.cpp around line 36 and inspect how the data collection is constructed. Compare the communicator used there with the mesh communicator, then verify the construction works when a downstream user has defined custom communicators.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- distributed-systems
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100