llnl / llnl/smith

Remove non-time varying boundary condition options

Open
#1,004 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
245
Forks
36
Avg merge
8d 23h
Merged PRs (30d)
4

Description

it might be worth only supporting the function signatures that include time, so there's half as many b.c. overloads to deal with

_Originally posted by @samuelpmishLLNL in https://github.com/LLNL/serac/pull/1003#discussion_r1334757263_

Contributor guide

Open the contributing guide

Research direction

The issue names no files, tests, or entry points; begin by locating the boundary-condition overloads and reviewing the discussion referenced from PR #1003. Confirm which non-time-varying signatures are supported and identify the relevant test coverage before making the overload set consistently time-dependent.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
hpc
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.