llnl / llnl/scr

record control directory in file within prefix directory for postrun scripts

Open
#358 0 comments 0 reactions 1 assignee View on GitHub

@adammoody is already working on this.

Since Jun 9, 2021.

Dominant language
C
Stars
108
Forks
37
PR merge metrics
No merged PRs in 30d

Description

The scr_postrun script needs to know the control directory in order to query for datasets to scavenge:

https://github.com/LLNL/scr/blob/37b11f8556e5942899a81d339d00eb4cb7a1ea4d/scripts/common/scr_postrun.in#L95

The control directory used to be a constant set at configure time, so it could be hardcoded on the install step. However, the user is now free to change the control directory by setting the SCR_CNTL_BASE parameter, including through calls to SCR_Config.

This is also used in the run and list_down_nodes scripts, e.g.,:

https://github.com/LLNL/scr/blob/37b11f8556e5942899a81d339d00eb4cb7a1ea4d/scripts/SLURM/scr_run.in#L106
https://github.com/LLNL/scr/blob/37b11f8556e5942899a81d339d00eb4cb7a1ea4d/scripts/SLURM/scr_list_down_nodes.in#L171

We need to record this value in the prefix directory so that the postrun script can read it. While at it, we could perhaps also record the set of cache directories being used in the same file.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.