llnl / llnl/scisample

Better error reporting for scisample

Open
#3 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1
Forks
3
PR merge metrics
No merged PRs in 30d

Description

Summary
Make scisample error reporting more like study validation error reporting.
What is the current behavior?

```
2020-10-16 13:30:36 - ERROR - Sampler data is invalid
Traceback (most recent call last):
{ FIFTY-TWO lines of traceback }
codepy.scisample.utils.SamplingError: Sampler data is invalid
```

What is the desired behavior?

Reporting like that for study validation error reporting.
```
2020-10-16 13:30:53 - ERROR - Error in phase or flavor data for run-generate-baseline
2020-10-16 13:30:53 - ERROR - '01:00' does not match '^([0-9][0-9]-)?[0-9]{1,2}:[0-9][0-9]:[0-9][0-9]$'

Failed validating 'pattern' in schema['properties']['walltime']:
{'pattern': '^([0-9][0-9]-)?[0-9]{1,2}:[0-9][0-9]:[0-9][0-9]$',
'type': 'string'}

On instance['walltime']:
'01:00'
2020-10-16 13:30:53 - ERROR - Study is missing data, cannot write a maestro specifiation
```

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the current scisample SamplingError reporting and compare it with the study validation error-reporting path. Reproduce the invalid sampler-data case and make the output include the validation details and final error message in the style shown; confirm the traceback is replaced by the requested validation report.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.