llnl / llnl/scisample

Clean up pytest code.

Open
#14 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1
Forks
3
PR merge metrics
No merged PRs in 30d

Description

You can add an argument to assertTrue which will be printed if the test fails, this can be useful when using a helper function to test multiple things.

Originally posted by @daub1 in https://github.com/LLNL/scisample/pull/6#r585674929

If I have time, I will look into pytest.parametrize. https://docs.pytest.org/en/stable/parametrize.html

Reply…

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the pytest tests that use helper functions to check multiple conditions. Review the existing assertions, add failure messages where useful, and evaluate the linked pytest.parametrize documentation; done means the test code is cleaner and failures identify the relevant condition.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.