llnl / llnl/rose

GNU Attributes like gnu_attribute_alignment not copied by copy constructor and operator==

Open
#267 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
688
Forks
144
PR merge metrics
No merged PRs in 30d

Description

Hi all,

I found a potential issue that GNU attributes are not copied by the copy constructor and operator=() of classes like SgTypeModifier (e.g. https://github.com/rose-compiler/rose/blob/weekly/src/ROSETTA/Grammar/Support.code). Because of that, those attributes will get lost on copying.

Is this intended or a bug that can be fixed?

Thanks!

Contributor guide

No contributing guide indexed for this repository

Research direction

Read src/ROSETTA/Grammar/Support.code and inspect how classes such as SgTypeModifier implement their copy constructor, operator=(), and operator==(). Trace how GNU attributes such as gnu_attribute_alignment are represented, then verify that copying and equality preserve them; the issue provides no test location, so a suitable regression test would need to be identified.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.