Construction of dump dirpath not appending '/'
Open
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 8
- Forks
- 2
- PR merge metrics
- No merged PRs in 30d
Description
The check for whether PDUMP_DUMP_DIR ends with a '/' is faulty. The fix is to replace line 103:
`if (!dump_dir_str[back] == '/') {`
... with this:
`if (dump_dir_str[back] != '/') {`
... in perf_dump.C.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open perf_dump.C at line 103 and inspect the PDUMP_DUMP_DIR path construction and trailing-slash check. The issue is done when the check correctly identifies paths without a trailing '/' so the dump directory path is constructed with the needed separator.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- performance
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100