llnl / llnl/mrid

Interpolation Update

Open
#29 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Update cpp/Interpolate.h to have the following:

  • Correct casting inside template functions for arithmetic calculations.
  • Move current template functions constraints (ifs) in comments/docs
  • Add in correct checks for divide by 0.
  • Document future use of constexpr on the interpolation functions
  • Update template function parameters to this: x, x1, x2, y1, y2

Ref #15 & Ref !51

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the template functions in cpp/Interpolate.h and review the related context in refs #15 and !51. Check the existing arithmetic, constraints, parameter names, and division handling; done means the requested casts, checks, documentation comments, constexpr note, and parameter updates are present.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.