llnl / llnl/mpiP

ISO C99 and later do not support implicit int

Open
#54 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
112
Forks
35
PR merge metrics
No merged PRs in 30d

Description

Hi,

I am trying to build mpiP using "icx" on intel CPUs, but met the following issue. how to fix it?

pc_lookup.c:115:41: error: parameter 'data' was not declared, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
find_address_in_section (abfd, section, data)
                                        ^
pc_lookup.c:118:6: error: expected function body after function declarator
     PTR data;
     ^
pc_lookup.c:119:1: error: expected identifier or '('
{
^
pc_lookup.c:438:58: error: use of undeclared identifier 'PTR'
  bfd_map_over_sections (abfd, find_address_in_section, (PTR) NULL);
                                                         ^
pc_lookup.c:438:32: error: use of undeclared identifier 'find_address_in_section'
  bfd_map_over_sections (abfd, find_address_in_section, (PTR) NULL);
                               ^
pc_lookup.c:480:35: error: use of undeclared identifier 'PTR'
                                 (PTR) NULL);
                                  ^
pc_lookup.c:479:44: error: use of undeclared identifier 'find_address_in_section'
          bfd_map_over_sections (fso->bfd, find_address_in_section,
                                           ^
7 errors generated.
make: *** [Rules.mak:6: pc_lookup.o] Error 1

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the failure with icx and inspect pc_lookup.c around lines 115-119, then trace the PTR references near lines 438 and 479-480. The change is complete when mpiP builds successfully with the reported compiler errors resolved.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
performance
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.