llnl / llnl/maestrowf

Batch additonal args does not work

Open
#447 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
161
Forks
49
PR merge metrics
No merged PRs in 30d

Description

The Maestro documentation states that custom arguments `args` can be passed to the `batch` block such that the user can specify additional scheduler writing steps that are not default keys in Maestro. The docs state that `args` is passed as a dictionary in the `yaml` file. For example:
```
batch:
type: lsf
host: lassen
bank: flask
queue: pdebug
args:
alloc_flags: ipisolate
```
which should result in writing a bash script like so:
```
#BSUB -nnodes 1
#BSUB -q pdebug
#BSUB -G flask
#BSUB -W 00:30
#BSUB -alloc_flags ipisolate
```
However, when in reality `#BSUB -alloc_flags ipisolate` does not show up in the file. My guess is that the code that should be writing this would be located in `maestrowf/interfaces/script/lsfscriptadapter.py`, but as far as I can tell, no code related to `args` is present.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the documented batch `args` example and inspect `maestrowf/interfaces/script/lsfscriptadapter.py` for how YAML batch settings become LSF directives. Confirm the generated script includes `#BSUB -alloc_flags ipisolate` when the example configuration is used.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
hpc, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.