llnl / llnl/maestrowf

"Depends" Funnel Edge Case

Open
#378 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
161
Forks
49
PR merge metrics
No merged PRs in 30d

Description

Discussed in https://github.com/LLNL/maestrowf/discussions/376

Originally posted by MIAllende September 15, 2021
Seeing an edge case in which a funnel step is not working properly.

Here is a graphic in which there are two parameterized runs (Run1, Run2). If one of the postprocessing steps for Run1 fails (failure visualized as a red square), I expect the subsequent and dependent post-processing steps to fail. Maestro is doing this successfully.

The issue is that the Plotr step for other, separate runs is also failing. Plotr depends on Postr_, however I just want it to depend on the postr_ steps for its parent run, NOT all other runs.

Screen Shot 2021-09-15 at 8 11 16 AM

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading discussion 376 and the issue's two-run funnel example. Reproduce the case with parameterized Run1 and Run2 workflows, then trace how the Depends pattern resolves Postr_* steps. Done means a Plotr step depends only on the Postr steps for its parent run while failure propagation remains correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.