llnl / llnl/maestrowf

The FluxAdapter walltime cannot be more than 24 hours

Open
#164 1 comment 0 reactions 1 assignee View on GitHub

@FrankD412 is already working on this.

Since Nov 17, 2018.

Adapters bug Confirmed Good First Issue
Dominant language
Python
Stars
161
Forks
49
PR merge metrics
No merged PRs in 30d

Description

When using the FluxAdapter (and by proxy, probably the FluxSpectrumAdapter) the wall time for a scheduled step cannot exceed 24 hours. This bug is probably related to the use of the datetime class which is most likely meant to only represent time in 24 hour spans which means that our use of the datetime class is not within the expected use. The solution to this issue will likely be coding a new version of the _convert_walltime_to_seconds method in both the flux adapter classes.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.