Missing setxattr mdops
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 77
- Forks
- 21
- PR merge metrics
- No merged PRs in 30d
Description
Hi,
I noticed that the setxattr metadata op counter (eg. from `lctl get_param mdt.*.md_stats`) is missing from cerebro lmt_mdt metrics and thus LMT itself.
I added "setxattr" at the end of optab_mdt_v1 in liblmt/mdc.c so that cerebro is now properly reporting the value. Actually, I'm using cerebro lmt_mdt directly so that's fine with me, however, this quick change breaks LMT tests. Also I suppose other code changes should probably be done to LMT itself for a full support (ltop, etc.).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in liblmt/mdc.c at optab_mdt_v1 and inspect the LMT tests that fail when setxattr is added. Then trace how the counter reaches cerebro lmt_mdt and check the mentioned LMT consumers such as ltop. Done means setxattr is supported across the relevant LMT paths and the tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- observability-sre
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100