llnl / llnl/libROM

Building libROM errors

Open
#319 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
236
Forks
47
PR merge metrics
No merged PRs in 30d

Description

I was trying to build libROM for the first time, and I was able to compile the library but the executable of the examples gave linking errors.

On closer inspection it was not able to find mpicxx libraries at the linking stage.
I was able to fix it by adding `${MPI_CXX_LIBRARIES}` to a couple of `target_link_libraries` statements.
This mirrors an already present '`${MPI_C_LIBRARIES}`'.

Would this be a worth while bug fix? Or did I do something wrong on my end?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the example build definitions for target_link_libraries statements that already use MPI_C_LIBRARIES, then compare their handling of MPI_CXX_LIBRARIES. Confirm that the example executables link successfully with the C++ MPI libraries and that the existing C MPI linkage remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.