llnl / llnl/libROM

i build librom in windows and i fond a memory leak

Open
#314 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
236
Forks
47
PR merge metrics
No merged PRs in 30d

Description

when i use
`CAROM::Matrix* interpolated_matrix = interpolator.interpolate(&desired_point);`
Memory increases by 4MB each time it is called.
So i check the code,when call dposv in void MatrixInterpolator::obtainLambda() make it.
so , I replaced dposv with eigen

```
Eigen::Map A(B->getData(), gamma_size, gamma_size);

//
Eigen::Map X(f_T->getData(), gamma_size, num_elements);

//
Eigen::LLT llt(A);

//
if (llt.info() != Eigen::Success) { /* error */ }
llt.solveInPlace(X);
```

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in MatrixInterpolator::obtainLambda() and reproduce the issue by repeatedly calling interpolator.interpolate with the shown input. Compare memory behavior around the dposv call and the reported Eigen replacement. Done means repeated interpolation no longer increases memory unexpectedly, with relevant tests or a reproducible check covering the behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.