Hard-coded values in NNLS solver
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 236
- Forks
- 47
- PR merge metrics
- No merged PRs in 30d
Description
Line 66 and 163 of `lib/linalg/NNLS.cpp` use hard-coded values of `n_proc_max_for_partial_matrix_ = 15` and `nb = 3`, which seem to be used mainly for distributing the matrix.
- There is no sufficient description as to why these values are chosen.
- For better scalability of this solver, shouldn't these values be determined by the users?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in lib/linalg/NNLS.cpp at lines 66 and 163, then trace how n_proc_max_for_partial_matrix_ and nb affect matrix distribution. Determine why 15 and 3 were chosen and whether users should configure them; the issue is done only when the intended behavior and any required configurability or documentation are agreed and covered appropriately.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- distributed-systems, performance
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100