llnl / llnl/libROM

`Matrix::orthogonalize()` works only for distributed case.

Open
#232 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C++
Stars
236
Forks
47
PR merge metrics
No merged PRs in 30d

Description

Based on the definition in `lib/linalg/Matrix.cpp`, `void Matrix::orthogonalize()` works only when the matrix is distributed (in parallel case). It should have a line:
```
CAROM_VERIFY(distributed());
```

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open lib/linalg/Matrix.cpp and inspect Matrix::orthogonalize(), focusing on its behavior for non-distributed matrices. Confirm the intended distributed-only precondition from the issue, then verify that the function rejects unsupported cases as described. Done means the stated validation is present and the relevant behavior is covered by the project's existing checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
distributed-systems
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.