llnl / llnl/irep

Request BUILD_INTERFACE addition to irep-config.cmake

Open
#12 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Lua
Stars
16
Forks
1
PR merge metrics
No merged PRs in 30d

Description

We Modified share/irep/irep-config.cmake to get exo to export properly. So far we've had to add BUILD_INTERFACE before CMAKE_Fortran_MODULE_DIRECTORY and CMAKE_CURRENT_SOURCE_DIR In target_include_directories.

Pasting the lines into a code block got weird given symbols, so I hope this is clear. Please let me know if you need more details. I can give you a file on LC if that helps.
We're currently using
irep: bda090beb03e8505de4b067f79826e15f0b7f867

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with share/irep/irep-config.cmake and inspect the target_include_directories entries using CMAKE_Fortran_MODULE_DIRECTORY and CMAKE_CURRENT_SOURCE_DIR. Compare them with the requested BUILD_INTERFACE additions and verify that the resulting configuration exports exo correctly. No test or validation command is named in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, fortran
Domain
build-system
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.