llnl / llnl/conduit

Node::compact_elements_to we rely on no-op for one case, but comment suggests that is an error case

Open
#780 0 comments 0 reactions 0 assignees View on GitHub
task
Dominant language
C++
Stars
248
Forks
72
Avg merge
1d 16h
Merged PRs (30d)
15

Description

`Node::compact_elements_to` --- the if statement has a comment that when true, we should have an error (compacting something that can't be compacted)

if we change this to an error, tests fail.

It might be that this is just a pass through and should be a no-op, but we should understand deeper.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the Node::compact_elements_to entry point and trace the condition whose comment describes an error case. Check the existing tests that fail when this behavior changes, then determine whether the condition should remain a no-op or report an error. Done means the behavior and comment agree and the affected tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
data
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.