llnl / llnl/conduit

Conduit Node: set_external T const*

Open
#577 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature
Dominant language
C++
Stars
248
Forks
72
Avg merge
1d 16h
Merged PRs (30d)
15

Description

With regards to conduit::node::set_external:
At least for floating point types and int, conduit lacks overloads for T const* types.

Currently seens as compile error for particles in AMReX:
Src/Extern/Conduit/AMReX_Conduit_Blueprint_ParticlesI.H

Refs.:

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with conduit::node::set_external and the referenced AMReX_Conduit_Blueprint_ParticlesI.H lines 69-70, where the const-pointer call currently fails to compile. Compare the existing overloads for floating-point types and int, then verify that the AMReX particles usage compiles with const pointer inputs.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend-api-design, hpc
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.