CMP0054 warning
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 248
- Forks
- 72
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 15
Description
```
CMake Warning (dev) at thirdparty_builtin/civetweb-0a95342/CMakeLists.txt:88 (if):
Policy CMP0054 is not set: Only interpret if() arguments as variables or
keywords when unquoted. Run "cmake --help-policy CMP0054" for policy
details. Use the cmake_policy command to set the policy and suppress this
warning.
Quoted variables like "MSVC" will no longer be dereferenced when the policy
is set to NEW. Since the policy is not set the OLD behavior will be used.
This warning is for project developers. Use -Wno-dev to suppress it.
```
code flagged:
`if("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang")`
I assumed we are just interested in the string "Clang", but maybe that was a magic case in the past -- like it mentions for "MSVC" ?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at thirdparty_builtin/civetweb-0a95342/CMakeLists.txt:88 and read the CMake CMP0054 policy documentation, focusing on the quoted CMAKE_CXX_COMPILER_ID condition. Confirm the intended behavior for Clang, update the affected CMake configuration accordingly, and rerun CMake to verify the developer warning is gone.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, cpp
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100