llnl / llnl/conduit

potential path traversal performance improvements

Open
#390 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

performance
Dominant language
C++
Stars
248
Forks
72
Avg merge
1d 16h
Merged PRs (30d)
15

Description

In conduit::Node and/ or conduit::Schema, there are two basic targets for performance analysis and improvements

  • investigate using of char* and direct offsets to avoid string copies during path splitting and path traversals
  • investigate reducing the use of recursion for path traversals

Note: The current code was written in a style with correctness in mind (simple use of string helper utilities and use of recursion). Performance hasn't been a bit issue to date, but I am sure there is room for improvement.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by examining conduit::Node and conduit::Schema, focusing on path splitting and path traversal code. Profile the current string-copying and recursive behavior before evaluating the two proposed optimization areas: char* and direct offsets, and reduced recursion. Done means measurable performance improvements are demonstrated without sacrificing correctness.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
performance
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.