llnl / llnl/conduit

roundtrip json parsing of nans and infs

Open
#163 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature
Dominant language
C++
Stars
248
Forks
72
Avg merge
1d 16h
Merged PRs (30d)
15

Description

expanding from #160 ,

newer versions of rapidjson provide kParseNanAndInfFlag, which handles inf, -inf and nan.
Again, json itself doesn't handle these, so for the web browser we may need to send as strings.

If we present as strings, we could look for "-inf", "inf", and "nan" strings as part of json sanitize and fix them before handing to rapidjson. However need need to make sure we only transform json values (and not ids), which complicates the json santize logic.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the work from #160 and the JSON sanitize logic, then compare how RapidJSON's kParseNanAndInfFlag handles inf, -inf, and nan. Done should mean round-tripping these values for browser-facing JSON without transforming matching strings in IDs or other non-value fields.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, json
Domain
data, hpc
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.