llnl / llnl/conduit

Tests should blow away old result files to avoid errors

Open
#1,272 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
248
Forks
72
Avg merge
1d 16h
Merged PRs (30d)
15

Description

I ran into this when switching branches, t_blueprint_mpi_mesh_relay began to mysteriously fail. mpi_mesh_examples_braid was the culprit; deleting the files it generated made the test pass. The error message the test gave me had something to do with the file already existing and being incompatible with what was being written.

In general we should try to always call remove_path_if_exists before writing files from conduit tests.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the t_blueprint_mpi_mesh_relay test and the mpi_mesh_examples_braid example named in the issue. Trace where the example writes its generated files and review the existing remove_path_if_exists helper. Done means stale result files are safely removed before writing and the test passes after switching branches.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
testing-qa
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.