Test failures when building with Intel 19.x optimized.
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 248
- Forks
- 72
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 15
Description
I was testing an optimized Intel build of `develop` and noticed that 2 test failures occur on rzgenie. It appears related to node differencing. For partition, maybe the floating point epsilon is too small? The failure did not occur when using Debug mode.
This failure was with 19.0.4.
Update: Intel 19.1.2 fails too
The failing tests are:
* t_conduit_node_compare
* t_blueprint_mesh_partition
Here is how the code was configured:
```
#!/bin/bash
function build_with_intel
{
cmake -DBUILD_SHARED_LIBS:BOOL=OFF \
-DCMAKE_C_COMPILER=icc \
-DCMAKE_CXX_COMPILER=icpc \
-DCMAKE_Fortran_COMPILER=ifort \
-DCMAKE_C_FLAGS="-gcc-name=/usr/tce/packages/gcc/gcc-8.1.0/bin/gcc -std=gnu11" \
-DCMAKE_CXX_FLAGS="-gxx-name=/usr/tce/packages/gcc/gcc-8.1.0/bin/g++ -std=c++14 " \
-DCMAKE_Fortran_FLAGS=-gcc-name=/usr/tce/packages/gcc/gcc-8.1.0/bin/gcc \
-DCMAKE_BUILD_TYPE:STRING=Release \
-DENABLE_MPI=ON \
-DENABLE_FORTRAN=ON \
-DENABLE_DOCS=OFF \
../src
}
build_with_intel
```
Here is some output from t_conduit_node_compare:
```
%: t_conduit_node_compare
Running main() from /path/conduit_adjset/conduit/src/blt/thirdparty_builtin/googletest-master-2020-01-07/googletest/src/gtest_main.cc
[==========] Running 9 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 9 tests from conduit_node_compare
[ RUN ] conduit_node_compare.compare_basic
[ OK ] conduit_node_compare.compare_basic (0 ms)
[ RUN ] conduit_node_compare.compare_leaf_numeric
/path/DT/conduit_adjset/conduit/src/tests/conduit/t_conduit_node_compare.cpp:142: Failure
Value of: diff_nodes(n, o, info)
Actual: false
Expected: true
/path/DT/conduit_adjset/conduit/src/tests/conduit/t_conduit_node_compare.cpp:142: Failure
Value of: diff_nodes(n, o, info)
Actual: false
Expected: true
/path/conduit_adjset/conduit/src/tests/conduit/t_conduit_node_compare.cpp:142: Failure
Value of: diff_nodes(n, o, info)
Actual: false
Expected: true
/path/conduit_adjset/conduit/src/tests/conduit/t_conduit_node_compare.cpp:142: Failure
Value of: diff_nodes(n, o, info)
Actual: false
Expected: true
[ FAILED ] conduit_node_compare.compare_leaf_numeric (1 ms)
```
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the optimized Intel 19.x configuration and run t_conduit_node_compare and t_blueprint_mesh_partition, starting with t_conduit_node_compare.cpp around the reported failure. Compare Release and Debug behavior while investigating node differencing and the possible floating-point epsilon issue; done means both tests pass in the optimized Intel build.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, cpp
- Domain
- build-system, compilers, testing-qa
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100