llnl / llnl/camp

Add a configured header instead of relying on cmake defines

Open
#41 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
107
Forks
26
Avg merge
8d 11h
Merged PRs (30d)
2

Description

In umpire, after importing camp using `find_package`, this bit of cmake is required to get a CUDA build of umpire working:

```
blt_add_target_definitions(
TO camp
SCOPE INTERFACE
TARGET_DEFINITIONS CAMP_HAVE_CUDA)
```

Could we add a configurable header that handles this issue and precludes inconsistency across projects using camp?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the CMake package configuration after find_package and the existing CAMP_HAVE_CUDA target definition used by Umpire. Determine how a configurable header could provide the same CUDA setting consistently to projects importing camp. Done means the configuration is exposed without project-specific target definitions and the relevant CMake integration is verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp
Domain
build-system
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.