Override system include flag when necessary
- Dominant language
- C++
- Stars
- 296
- Forks
- 66
- Avg merge
- 1h 3m
- Merged PRs (30d)
- 1
Description
@tomstitt noticed that CMake was not properly using `isystem` for system includes with the XL compiler and discovered that this can be overridden via the CMake variable: `CMAKE_INCLUDE_SYSTEM_FLAG_CXX`
e.g.
```cmake
-DCMAKE_INCLUDE_SYSTEM_FLAG_CXX="-isystem"
```
Should BLT incorporate this?
At the very least, we might consider noting this in our user/API docs.
Note: This could potentially also be helpful for versions of MSVC that do not properly set its corresponding system include flag.
Contributor guide
Research direction
No file or test is named. Review BLT's CMake configuration and user/API documentation, then investigate how CMAKE_INCLUDE_SYSTEM_FLAG_CXX is currently handled for C++ compilers. Done means either the override is supported and documented, or the documentation clearly explains how users can apply it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, cpp
- Domain
- build-system
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100