llnl / llnl/blt

Compiler error with gcc+hip

Open
#662 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
296
Forks
66
Avg merge
1h 3m
Merged PRs (30d)
1

Description

Hi,

Is it possible to split the hip compiler from the wrapper? The current hip build seems to only support clang.

https://github.com/LLNL/blt/blob/29eecef7652728ec37d9fe0b7d7f41e3184ac7eb/cmake/thirdparty/BLTSetupHIP.cmake#L83-L87

I'm trying to compile Ascent on Frontier using PrgEnv-gnu, but the gcc doesn't support hip yet.
```
g++: error: unrecognized command-line option '--rocm-path=/opt/rocm-5.3.0'
```
https://github.com/Alpine-DAV/ascent/issues/1192

Thanks!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at cmake/thirdparty/BLTSetupHIP.cmake lines 83-87 and inspect how the HIP compiler and wrapper are configured. Reproduce the Ascent/Frontier PrgEnv-gnu command described in the issue; done means the HIP setup no longer passes the unsupported --rocm-path option to GCC while retaining the existing clang configuration.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp
Domain
build-system, compilers, hpc
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.