llnl / llnl/blt

Support building with Ninja using MSVC

Open
#614 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
296
Forks
66
Avg merge
1h 3m
Merged PRs (30d)
1

Description

When compiling using MSVC and Ninja the compiler flags are not correctly set cause the tool fails to identify the compiler.
This can be avoided by extending the identification mechanism for compiler in SetCompilerOptions.cmake, e.g. also checking for MSVC compiler ID.

Contributor guide

Open the contributing guide

Research direction

Start in SetCompilerOptions.cmake and inspect how compiler identification and flags are selected for MSVC with the Ninja generator. Reproduce or inspect the MSVC/Ninja configuration, then verify that the compiler is identified correctly and the appropriate flags are set when building with that combination.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.