BLT cmake language suport initialization difference between cuda and hip
Open
Nobody has claimed this yet.
bug
- Dominant language
- C++
- Stars
- 296
- Forks
- 66
- Avg merge
- 1h 3m
- Merged PRs (30d)
- 1
Description
BLT calls `enable_language(cuda)` when cuda is on:
https://github.com/LLNL/blt/blob/8c229991e65e7a9603c621b47cb3ba158bb7468c/cmake/thirdparty/SetupCUDA.cmake#L67
However, it doesn't call: `enable_language(hip)` when hip is on.
We should be consistent.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with cmake/thirdparty/SetupCUDA.cmake at the linked line and inspect the corresponding HIP-enabled setup path for the language initialization behavior. Make the HIP path consistent with CUDA when HIP is enabled, then run the relevant CMake configuration or testing workflow to confirm HIP projects configure successfully.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100