Patch `fruit` against "Null literal string" error
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 296
- Forks
- 66
- Avg merge
- 1h 3m
- Merged PRs (30d)
- 1
Description
@tomstitt reported a compiler error with `fruit` when using the XL compiler on LLNL's blueos clusters.
```
.../blt-ddd5a0c/thirdparty_builtin/fruit-3.4.1/fruit.f90, line 292.53: 1515-009 (E) Null literal string is not permitted. A single blank is assumed.
.../blt-ddd5a0c/thirdparty_builtin/fruit-3.4.1/fruit.f90, line 1083.27: 1515-009 (E) Null literal string is not permitted. A single blank is assumed.
.../blt-ddd5a0c/thirdparty_builtin/fruit-3.4.1/fruit.f90, line 1097.15: 1515-009 (E) Null literal string is not permitted. A single blank is assumed.
.../blt-ddd5a0c/thirdparty_builtin/fruit-3.4.1/fruit.f90, line 1109.15: 1515-009 (E) Null literal string is not permitted. A single blank is assumed.
```
The offending lines are of the form:
https://github.com/LLNL/blt/blob/74d4e534dea3c8fa7bfa4c6f9d17eb37a1230c7e/thirdparty_builtin/fruit-3.4.1/fruit.f90#L292
According to @ltaylor16 :
```
The fix is to add the explicit blank. var = "" should be var = " ".
Looks like this should be fixed in blt. We're using version 3.4.1. Version 3.4.3 is available but does not fix this particular problem.
```
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open thirdparty_builtin/fruit-3.4.1/fruit.f90 and inspect the reported lines 292, 1083, 1097, and 1109. Check the empty string literals against the issue's compiler diagnostic, then verify that the XL compiler no longer reports the null literal string errors.】【。
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fortran
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100