llnl / llnl/blt

Create test for clangformat regex

Open
#504 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

clang code checks
Dominant language
C++
Stars
296
Forks
66
Avg merge
1h 3m
Merged PRs (30d)
1

Description

We keep running into problems with this regex. We should add a test that has commonly hit strings. Here are a few:

clang-format version 11.0.1
Cray clang-format version 12.0.0 (59041842ced75ac192c0f1331989ae45f58d7caf)
clang-format version 10.0.0-4ubuntu1 patch2.somethingsomething

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the clang-format regex and its existing test entry point in the repository. Add coverage for the three version strings listed in the issue, including the Cray and Ubuntu variants, and confirm the test distinguishes valid clang-format output from unsupported strings.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake
Domain
build-system, testing
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.